Repository navigation
Change the artifactId when building FIPS-compliant netty-tcnative-boringssl-static - #945
Merged
Merged
Conversation
…ingssl-static Motivation: netty-tcnative-boringssl when compiled for default mode or FIPS mode result in the same artifactId, same classifier, same version number and yet have a very significant different feature. It is not possible to store both builds in a repository such as Artifactory. To resolve this issue I made it so FIPS-mode builds get a different artifactId. Default mode build artifactId: netty-tcnative-boringssl-stati FIPS mode build artifactId: netty-tcnative-boringssl-static-fips Modifications: based on the active maven profile... - Change the artifactId - Add a field to the jar's manifest to state whether it was built with FIPS support Result: When built with the fips-boringssl-static profile the jar file names will now be netty-tcnative-boringssl-static-fips-2.0.75.Final-SNAPSHOT*.jar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the artifactId when building FIPS-compliant netty-tcnative-boringssl-static
Motivation:
netty-tcnative-boringssl when compiled for default mode or FIPS mode result in the same artifactId, same classifier, same version number and yet have a very significant different feature. It is not possible to store both builds in a repository such as Artifactory. To resolve this issue I made it so FIPS-mode builds get a different artifactId.
Default mode build artifactId: netty-tcnative-boringssl-stati
FIPS mode build artifactId: netty-tcnative-boringssl-static-fips
Modifications:
based on the active maven profile...
Result:
When built with the fips-boringssl-static profile the jar file names will now be netty-tcnative-boringssl-static-fips-2.0.75.Final-SNAPSHOT*.jar